Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create parent dir when linking file #253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ibotty
Copy link

@ibotty ibotty commented Apr 27, 2023

fixes #161

@ibotty ibotty requested a review from oknozor as a code owner April 27, 2023 10:03
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.87%. Comparing base (d3bd97d) to head (bf73add).

Files with missing lines Patch % Lines
src/paths/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   74.88%   74.87%   -0.02%     
==========================================
  Files          14       14              
  Lines        2031     2034       +3     
==========================================
+ Hits         1521     1523       +2     
- Misses        510      511       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ibotty
Copy link
Author

ibotty commented Apr 28, 2023

The tests fail because of other part in the code. I can submit fixes (cargo update) so that the tests run. And I can also fix the clippy warning. I'd assume it's not part of this PR though.

@oknozor
Copy link
Owner

oknozor commented Oct 23, 2024

I am really sorry I had to rewrite a part of the commit log. I would advice cherry picking if applicable.

@ibotty ibotty force-pushed the create-parent-dir branch from 8285b32 to bf73add Compare October 25, 2024 08:57
@ibotty
Copy link
Author

ibotty commented Oct 25, 2024

Just cherry-picked and rebased to main branch. This applied cleanly. Please consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Automatically create missing folders
2 participants