Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite of Device Service #129

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Conversation

okwasniewski
Copy link
Owner

Summary:

This PR moves custom commands logic to a separate class

Changelog:

refactor: separate custom commands to a new class

Test Plan:

CI Green, test if custom commands work as before

@okwasniewski okwasniewski force-pushed the feat/customCommandsService branch 3 times, most recently from a318096 to 5fa88ea Compare September 8, 2024 16:54
@okwasniewski okwasniewski force-pushed the feat/customCommandsService branch from 5fa88ea to b397cae Compare September 8, 2024 16:58
@okwasniewski okwasniewski changed the title feat: move custom commands to separate class & add tests feat: rewrite of Device Service Sep 10, 2024
@okwasniewski okwasniewski force-pushed the feat/customCommandsService branch from 4d27a98 to 42e7f12 Compare September 10, 2024 12:37
@okwasniewski okwasniewski force-pushed the feat/customCommandsService branch from 42e7f12 to 6ca3bd0 Compare September 10, 2024 12:41
@okwasniewski okwasniewski force-pushed the feat/customCommandsService branch from 0c5404a to 9002faf Compare September 10, 2024 16:53
@okwasniewski okwasniewski force-pushed the feat/customCommandsService branch 10 times, most recently from a770046 to 888fd40 Compare September 12, 2024 18:25
@okwasniewski okwasniewski force-pushed the feat/customCommandsService branch from 888fd40 to 9a09601 Compare September 12, 2024 18:29
@okwasniewski okwasniewski merged commit d8b552e into main Sep 12, 2024
3 checks passed
@okwasniewski okwasniewski deleted the feat/customCommandsService branch September 12, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant