feat: add preference option to change MiniSim icon

[schrobingus]

Adds an option in the preferences for the user to change the menu bar icon for MiniSim. Addresses #69 (nice).

MiniSim.Demonstration.1.mp4

[okwasniewski]

Thanks for those changes! I've left few comments

[okwasniewski]

I think you can use the @AppStorage property wrapper to save directly to user defaults 👍🏻

[schrobingus]

From my testing, AppStorage does save directly, but the appearance of the Picker will not change without State. Both cannot be used simultaneously in a single variable (menuImageSelected) either. Two variables I'd say would likely not be advantageous to using onChange, but if you'd like, I can do that as well. How should I implement this?

[okwasniewski]

I've used AppStorage for Picker in this file: MiniSim/Views/Onboarding/SetupView.swift - check it out

[okwasniewski]

If you will use @AppStorage this also won't be needed

[schrobingus]

Thanks mate, I'll get to it in a few.

[schrobingus]

I've made the changes suggested, albeit I do have a concern regarding @AppStorage's usage. I've resolved the suggestions that have been applied. :)

[okwasniewski]

Can you make it return MenuImage enum that you've added?

And also as the default let's use MenuImage.iphone

[schrobingus]

Did that and it works great. Just noting though, Objective-C compliance had to be removed from menuImage, but I was able to rework the observer to that.

[okwasniewski]

let's move this logic to the MenuImage enum:

enum MenuImage: String, CaseIterable {
    case iphone = "iphone"
    case ipad = "ipad"
    case box = "box"
    
    var image: NSImage? {
        guard let itemImage = NSImage(systemSymbolName: self.rawValue, accessibilityDescription: self.rawValue) else {
            return nil
        }
        itemImage.size = NSSize(
            width:  (itemImage.size.width)  * 0.78,
            height: (itemImage.size.height) * 0.78)
        itemImage.isTemplate = true
        return itemImage
    }
}

[okwasniewski]

Then you can call MenuImage.iphone.image

[schrobingus]

configureMenuImages is only ran once ever (setup) because the image gets smaller and smaller every single time the function is reran, NSImage remembers the previous size every time. Pardon me if I misunderstand, but this change would supposedly assume that MenuImage.image would be called multiple times?

[okwasniewski]

Image was getting smaller and smaller because you was mutating the button image in this case each item would have its own image

[okwasniewski]

I'm using @AppStorage in MiniSim/Views/Onboarding/SetupView.swift and it works great with Picker so I'm not sure whats the issue here. Can you check out that file?

[schrobingus]

@okwasniewski Sorry for the long delay, I've been a bit busy lately. SetupView works because enableiOSSimulators and enableAndroidSimulators are changed before the menu setup is called. With menuImageSelected, it's a bit different, because the menu needs to change on the fly, as a @State would. I have seen examples of @AppStorage acting this way, but it isn't recurring for me for some reason.

For example, if I call enableAndroidSimulators in this way:

struct Preferences: View {
    ...
    @AppStorage(UserDefaults.Keys.enableAndroidEmulators, store: .standard) var enableAndroidEmulators: Bool = true

    var body: some View {
        Settings.Container(contentWidth: 400) {
                ...
                Settings.Section(title: "Enable Android Emulators:") {
                        Toggle(isOn: $enableAndroidEmulators) {
                        Text("Enable Android Emulators")
                }
                ...

it doesn't mutate whilst it's open, because @AppStorage doesn't call like @State, at least in this case.

[okwasniewski]

According to docs this initializer of NSImage shouldn't be used directly