Update to latest shipyard #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh cool! I just noticed these suggestions. We'll be able to merge once we've chosen a license for this codebase. |
|
Turns out I already have code in this repo 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR uses the new borrowing and system construction. I don't know when you'll use this version of shipyard but this crate will be ready.
I also simplified tests by using methods directly on
World. I'm not sure it's something you want but it's there just in case =)I should've made another branch for the last commit... I guess it's a bit late.
This last commit is even more up to personal preference, cherry pick anything you like.
About
TypeIdBuckets::entriesI don't think the outerVecis useful, the inner one might be best kept asVec.