Implement support for log with tracing-log
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colelawrence
approved these changes
Jul 17, 2022
|
@colelawrence friendly ping! Just wanted to make sure you know I don't have merge rights. Are we waiting for a second review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements proper support for
log, specifically being able to parse the metadata coming from there appropriately. I learned that from here tokio-rs/tracing#193.Additionally, I added an option to disable printing any additional fields.
tracing_subscriber::fmt::Layerimplements this for specific fields, like the target:Layer::with_target.I instead just added a blanket disable/enable to keep this PR small.
I can split this into two parts if desired.