Update logic for autoload or starting sessions. #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic to prevent autoloading/starting sessions when any arguments are supplied to neovim is to prevent session management from kicking in when editing a single file. This updates the logic to allow a single argument passed to neovim as long as the argument is an existing directory. When neovim is launched in this way it behaves the same as opening neovim with no arguments but has changed the working directory. This results in consistent behavior of the autoloading/starting of sessions when passing a directory argument to start neovim. See: olimorris#93
neandrake
commented
Dec 20, 2023
The main functionality in `init.lua` assumes using current working directory in most cases. This refactors these functions to allow passing in a directory instead. The default behavior is to now use the current directory unless neovim was started with a single directory argument, using that instead. This also special-cases `.` as `vim.fn.expand()` does not resolve that to the current working directory.
|
@Dioswilson I made some updates that I think will resolve most of the odd state you identified. |
olimorris
reviewed
Dec 21, 2023
|
This is a great PR. Thanks for your contribution. I tried to rename the functions and update the comment blocks (mainly to aid myself when it comes to maintaining) but couldn't push it to the PR...something up with my Git config. So will merge and then and re-apply them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to prevent autoloading/starting sessions when any arguments are supplied to neovim is to prevent session management from kicking in when editing a single file.
This updates the logic to allow a single argument passed to neovim as long as the argument is an existing directory. When neovim is launched in this way it behaves the same as opening neovim with no arguments but has changed the working directory.
This results in consistent behavior of the autoloading/starting of sessions when passing a directory argument to start neovim.
See: #93