fix: recover from uncaught extension errors #1440
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszu
commented
Jun 5, 2025
| const extensionRegistry = <ExtensionRegistry>{ getAll: () => [extension1, extension2] }; | ||
| const getValueMock = vi.fn().mockReturnValue([extension1.id, extension2.id]); | ||
| const settingsManager = <SettingsManager>{ getValue: (key, defaultValue) => getValueMock(key, defaultValue) }; | ||
| const mockedLogger = <Logger>({ error: vi.fn() } as unknown); |
There was a problem hiding this comment.
The as unknown intermediate cast is to avoid having to mock the unused debug/info/warn logger functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any extension raises an uncaught exception while generating search results, the user is presented with an ugly stack trace and the main UI stops updating (see e.g. #1411):
This PR simply catches exceptions that surface while iterating over extensions during search result retrieval and logs the errors instead of dying. No results are displayed from the offending extension: