Adds calculator #10
Open
Adds calculator #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliesilvester
commented
Jul 10, 2024
| class OddValueError(Exception): | ||
| pass | ||
|
|
||
| def calculate(): |
There was a problem hiding this comment.
Better with type hinting:
def calculator() -> None:
olliesilvester
commented
Jul 10, 2024
| class OddValueError(Exception): | ||
| pass | ||
|
|
||
| def calculate(): |
There was a problem hiding this comment.
Suggested change
| def calculate(): | |
| def calculate() -> None: |
olliesilvester
commented
Jul 10, 2024
| elif total % 2 == 0: | ||
| raise OddValueError(f"Total {total} is an odd number") | ||
| finally: | ||
| print(f"Yor total is {total}") |
There was a problem hiding this comment.
Your instead of yor
olliesilvester
commented
Jul 10, 2024
Comment on lines
+11
to
+12
| num1 = int(input("Input the first number: ")) | ||
| num2 = int(input("Input the second number: ")) |
There was a problem hiding this comment.
These can be floats as well, no need to convert to ints
olliesilvester
commented
Jul 10, 2024
| try: | ||
| num1 = int(input("Input the first number: ")) | ||
| num2 = int(input("Input the second number: ")) | ||
| total = num1 + num2 |
There was a problem hiding this comment.
If calculator errors on negative or odd numbers, we should do our checks on the inputs rather than on the total
olliesilvester
commented
Jul 10, 2024
| total = num1 + num2 | ||
| if total < 0: | ||
| raise NegativeValueError(f"Total {total} is less than zero") | ||
| elif total % 2 == 0: |
There was a problem hiding this comment.
Suggested change
| elif total % 2 == 0: | |
| elif total % 2 != 0: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7