Update core.js - Badge counter >999 #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the browser chrome is only wide enough for 3 chars, update the counter so that unreadfeeds count of >999 will show as "1k+"
|
Hi, @thereddestdog, I made a few small changes to your code to account for situations where someone might have more than 1,000 unread articles. Thank you again for your contribution! |
|
@olsh Thank you! Glad to help |
|
Please note that we can release the code when #281 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the browser chrome is only wide enough for 3 chars, update the counter so that unreadfeeds count of >999 will show as "1k+"
My very first PR, hope I'm doing it right! Also not that familiar with javascript and I can't test this so..