Update Prisma Dependencies by joojscript · Pull Request #33 · omar-dulaimi/prisma-class-validator-generator

joojscript · 2025-11-23T18:05:16Z

Update Prisma Dependencies to make Prisma Runtime a peerDependency, enabling compatibility with all versions (provided by consuming package)

Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.

If the UI is being changed, please provide screenshots.

When using Prisma 7+, as the @prisma/client runtime dependency is flagged as a dependency and not a peerDependency on package.json, it overwrites the current version, and breaks everything.

The fix is as easy as transferring all the runtime dependencies to peerDependencies.

❯ prisma generate
Loaded Prisma config from prisma.config.ts.

Prisma schema loaded from prisma/schema.prisma
Error: 
✔ Generated Prisma Client (7.0.0) to ./src/generated/prisma in 12ms

Prisma schema validation - (get-dmmf wasm)
Error code: P1012
error: Argument "url" is missing in data source block "db".
  -->  schema.prisma:11
   | 
10 | 
11 | datasource db {
12 |   provider = "postgresql"
13 | }
   | 

Validation Error Count: 1
[Context: getDmmf]

Prisma CLI Version : 6.19.0


error: "prisma" exited with code 1

References

Include any links supporting this change such as a:

GitHub Issue/PR number addressed or fixed

StackOverflow post

Related pull requests/issues from other repos

If there are no references, simply delete this section.

Closes #32

Summary by CodeRabbit

Chores
- Updated Prisma packages to version 7.
- Adjusted dependency management configuration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Update Prisma Dependencies to make Prisma Runtime a peerDependency, enabling compatibility with all versions (provided by consuming package)

coderabbitai · 2025-11-23T18:05:25Z

Walkthrough

Elementary, the case unfolds with surgical precision. The package configuration has been restructured, promoting Prisma dependencies from the common dependencies to peerDependencies, whilst simultaneously bumping the internal Prisma toolchain to version ^7. The culprit—dependency version conflicts—is thus neutralized with one decisive maneuver.

Changes

Cohort / File(s)	Summary
Prisma Peer Dependencies Configuration `package.json`	Migrated `@prisma/client` and `prisma` to peerDependencies to resolve version conflicts between Prisma 7+ and CLI 6.19; removed `prisma` from devDependencies
Internal Prisma Toolchain Update `package.json`	Updated `@prisma/generator-helper` and `@prisma/internals` to version ^7, relocated from previous configuration to align with new dependency structure

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

The modification is confined to a single file with straightforward dependency reorganization following a consistent pattern. No logic changes or multi-file impact.

Poem

🔍 A puzzle of versions, now clearly resolved,

Prisma's true nature in peerDeps evolved,

Toolchain ascended to seventh's new height,

Dependencies realigned—the fix shines bright! ✨

Pre-merge checks

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Update Prisma Dependencies' directly and accurately reflects the main change: updating Prisma-related package.json dependencies.
Linked Issues check	✅ Passed	The changes fully address the linked issue #32 by moving @prisma/client and prisma from dependencies to peerDependencies, preventing runtime version conflicts.
Out of Scope Changes check	✅ Passed	All modifications are strictly scoped to package.json dependency reorganization addressing the Prisma version compatibility issue; no extraneous changes detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 012aa54 and 9b8c879.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (1)

package.json (1 hunks)

🧰 Additional context used

🧠 Learnings (6)