Fix the testing for JDK 8 /11 by using --build-arg
#274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while working on building an image on JDK 17 to start testing ome/bioformats#3796 and ome/bioformats#3815 in our CI
The previous logic was based on environment variables and effectively using the same base image for both matrix builds.
486cddd uses the
--build-arg
option and also uses the<java_version>-slim-bullseye
Docker tag to ensure the image is Debian-based.To test this build look at the raw logs of the JDK8 and the JDK11 builds. Without this PR, the logs should indicate
/usr/local/openjdk-8
in both cases. With this PR the JDK version should match the matrix parameter