Release artifacts #3934
Release artifacts #3934
Conversation
There was a problem hiding this comment.
A few additional questions in terms of the proposed changes:
1- I am going back and forth about injecting the resolver:resolve step in components/bundle/bioformats_package.xml as proposed here vs centralizing all the targets involving some dependency resolution to ant/java.xml
2a- should the docs target be built as part of every run to catch future regressions?
2b- #3912 also modifies the logic of the Ant action to upload a set of artifacts for consumption. This addition could also be constructed a tag-specific step of the ant workflow assuming the relevant artifacts are all built
No blockers but possibly a few decisions that might be worth discussing as part of the @ome/formats weekly meeting.
I have tried various things to no success i.e. keeping it in
This is an important part of the release process and it does not take long so I think it should be included by default.
It could be. I follow the same pattern that we introduced in openmicroscopy mainly to keep things clearer. |
jburel
force-pushed
the
release_artifacts
branch
2 times, most recently
from
9f36942 to
0c62287
Compare
| <target name="docs" depends="javadoc-properties" | ||
| description="generate the Javadocs for most components"> | ||
| <echo>----------=========== Javadocs ===========----------</echo> | ||
| <path id="compile.classpath"/> |
There was a problem hiding this comment.
As mentioned in a previous version of this commit, this is equivalent to the approach I took in bf8076e#diff-fdeb882f159787e553f8d2b7f340d498880a8a54e60ae5dee163671dc9009018R203-R211 to fix the bundle generation target.
|
Conflicting PR. Removed from build BIOFORMATS-push#359. See the console output for more details.
|
There was a problem hiding this comment.
Overall the changes look good, agreed that ant docs should indeed be part of the process. The artifacts generated by the test in https://github.com/jburel/bioformats/releases/tag/v6.11.1-m1 all look to be correct.
This PR creates and uploads the release artifacts when a tag is pushed
4b1f685 is needed since the reference
compile/runtime.classpathis no longer found when ant 1.10 is used (that's the version installed via GHA). Open to alternative is someone knows oneTested via https://github.com/jburel/bioformats/releases/tag/v6.11.1-m1