Fix compile issues with JDK 17 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
approved these changes
May 11, 2022
There was a problem hiding this comment.
The proposed changes are straightforward and lift the ambiguity between java.lang.Record and loci.poi.hssf.record.Record allowing the component to build on Java 17.
The daily CI builds including the repository tests showed no obvious regression related to this fix. Merging and releasing as 0.3.5.
|
Released as @melissalinkert I am considering using ome/bioformats#3815 to collate the version bump for all the components related to Java 17 support. Would that work ? |
|
Using ome/bioformats#3815 for version bumps makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds should now run and pass.