Ensure that laplacian and gaussian scaling preserves dtype #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495
The gaussian and laplacian scaler functions don't preserve dtype - see issue above.
I looked at tests and there's 2 issues...
The check_downscaled function
ome-zarr-py/tests/test_scaler.py
Line 29 in b49986e
float64when the input was int16 - Fixed this test in the 2nd commit below.The tests
ome-zarr-py/tests/test_scaler.py
Line 74 in b49986e
ome-zarr-py/tests/test_scaler.py
Line 66 in b49986e
xfailflag. These 2 tests check dtype now, but not shape.