-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extinfo command #167
base: master
Are you sure you want to change the base?
Add extinfo command #167
Conversation
💯 As a part of this I can imagine wanting to |
|
Interesting... is this a python version thing? I use 3.12.9. |
It could be, I'm on an old env python 3.9.15. |
Yes, looks like it's supported from 3.10 on. As we still recommend 3.9 I'll remove that stuff again. |
select e from ExternalInfo as e | ||
where e.id = :id | ||
""" | ||
extinfo = conn.getQueryService().findByQuery(query, params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In think this needs to be a cross-group query findByQuery(query, params, conn.SERVICE_OPTS)
otherwise you won't see it if the extinfo isn't in your default group.
join fetch usedFile.originalFile as f | ||
join fetch f.hasher where image.id = :id | ||
""" | ||
fs = conn.getQueryService().findByQuery(query, params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cross-group query here too
for more information, see https://pre-commit.ci
@@ -108,6 +109,12 @@ | |||
|
|||
POLYGONS_HELP = """Export ROI Polygons on the Image or Plate in zarr format""" | |||
|
|||
EXTINFO_HELP = """Get the ExternalInfo path of an ome.zarr image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get or set...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get, because that's the default action.
I was trying to test this on a non-zarr image, by specifying the
It seems that there's something strange about |
There's a check if it is a ome.zarr: https://github.com/ome/omero-cli-zarr/pull/167/files#diff-2d64f99479103ff3050c633344ddf895f61491094e9dab65218a3ec17cbfcb59R177 As that's actually only intended to be used with zarr. Otherwise it wouldn't make sense to have it as omero-cli-zarr plugin!? |
The point is that you have a
but it doesn't work for me. Does it work for you? |
This command will automatically set the ExternalInfo for ome.zarr images imported using the omero-zarr-pixel-buffer.
I takes the path from the Fileset "usedFiles", which is assumed to only have one entry
..../SOME.ome.zarr/OME/METADATA.ome.xml
and then set the ExternalInfo lsid to the full path of the multiscale 5d image;..../SOME.ome.zarr/0
for an image..../SOME.ome.zarr/A/1/1
etc. for plates.Limitations: Only works for ome.zarr imported from the filesystem. And it's expected that the ome.zarr is a series with only that one image (
/0
) or a plate which path structure<row>/<column>/<field index>