Link url to image

[Rdornier]

Fixes #514 by adding a KVP on each image used a the figure. The KVP consists on the Figure URL

[will-moore]

A few flake8 errors in the build:

./omero_figure/views.py:373:39: E203 whitespace before ':'
./omero_figure/views.py:376:80: E501 line too long (116 > 79 characters)
./omero_figure/views.py:411:30: F821 undefined name 'rlist'
./omero_figure/views.py:411:80: E501 line too long (84 > 79 characters)
./omero_figure/views.py:414:26: F821 undefined name 'rlist'
./omero_figure/views.py:432:80: E501 line too long (101 > 79 characters)

NB: you should be able to use wrap( ["some string"] ) to wrap a list

[Rdornier]

Hi @will-moore

I fixed the flake8 errors.
I also fixed another bug to support the case when a figure already exists but the kvp is not yet created.

I finally noticed that BASE_WEBFIGURE_URL only contains the url from /figure/ and not from https://omero.server/webclient. Do you know how I can get this info ?

[will-moore]

You can use https://docs.djangoproject.com/en/5.1/ref/request-response/#django.http.HttpRequest.build_absolute_uri
e.g.

url = request.build_absolute_uri(reverse('load_figure', args=[file_id]))
map_ann.setValue([["Figure_%s_%s" % (fig_name, file_id), url]])

[will-moore]

Seems to be working fine from my testing so far...
I wonder if you could move that new code into a separate function(s), to keep the save_web_figure() function as simple/readable as possible.

[Rdornier]

Ok cool !

I wonder if you could move that new code into a separate function(s), to keep the save_web_figure() function as simple/readable as possible.

I agree, it could be better

I also noticed that I should remove the KVP from images when the figure is deleted, which is not yet the case.

[will-moore]

I think it would be better not to include the figure Name in the Key because it's tricky to handle re-naming.
E.g. when I renamed a Figure and saved it, I got a new KVP annotation created, and the old one will be forever left on the images, even when they are removed from the Figure:

Everything else seems to be working fine (delete Figure removes KVP etc).

[Rdornier]

Thanks for your feedback.
Indeed, this is annoying but I would prefer to keep the name of the figure so that users knows in which figure the image is used, without having to open it.
I've made the fix in that direction.

[will-moore]

Looking good, thanks.