-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix posix issue #418
Fix posix issue #418
Conversation
Trying to test this with the Insight merge build, but can't run it. Any ideas? Thought it might just be on OSX, but also got the same on Linux VM, running Java 11:
|
I'll just build/run it from your branch for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 Tested with a local build from the branch. Download image and attach a local file. I think that's two use cases this code would be used.
Maybe a problem with merge-ci. Maybe some PR that should not be included are included. We have seen that previously |
2 tests are currently failing on Windows see #416
with the error
This PR replaces the usage of
com.google.common.io.Files
directly byjava.nio.file.Files.
This PR is required to release a new version of omero-insigth