Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix posix issue #418

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Fix posix issue #418

merged 6 commits into from
Dec 18, 2023

Conversation

jburel
Copy link
Member

@jburel jburel commented Dec 17, 2023

2 tests are currently failing on Windows see #416
with the error

java.lang.UnsupportedOperationException: 'posix:permissions' not supported as initial attribute
    	at sun.nio.fs.WindowsSecurityDescriptor.fromAttribute(WindowsSecurityDescriptor.java:358)
    	at sun.nio.fs.WindowsFileSystemProvider.createDirectory(WindowsFileSystemProvider.java:492)
    	at java.nio.file.Files.createDirectory(Files.java:674)
    	at java.nio.file.TempFileHelper.create(TempFileHelper.java:136)
    	at java.nio.file.TempFileHelper.createTempDirectory(TempFileHelper.java:173)
    	at java.nio.file.Files.createTempDirectory(Files.java:950)
    	at com.google.common.io.TempFileCreator$JavaNioCreator.createTempDir(TempFileCreator.java:102)
    	at com.google.common.io.Files.createTempDir(Files.java:439)

This PR replaces the usage of com.google.common.io.Files directly by java.nio.file.Files.
This PR is required to release a new version of omero-insigth

@dominikl
Copy link
Member

Trying to test this with the Insight merge build, but can't run it. Any ideas? Thought it might just be on OSX, but also got the same on Linux VM, running Java 11:

~/Downloads/OMERO.insight-5.8.4-SNAPSHOT/bin$ ./omero-insight
Error: LinkageError occurred while loading main class org.openmicroscopy.shoola.Main
	java.lang.ExceptionInInitializerError: null

~/Downloads/OMERO.insight-5.8.4-SNAPSHOT/bin$ java --version
openjdk 11.0.21 2023-10-17
OpenJDK Runtime Environment (build 11.0.21+9)
OpenJDK 64-Bit Server VM (build 11.0.21+9, mixed mode)

@dominikl
Copy link
Member

I'll just build/run it from your branch for now.

Copy link
Member

@dominikl dominikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Tested with a local build from the branch. Download image and attach a local file. I think that's two use cases this code would be used.

@pwalczysko
Copy link
Member

Tested download and upload of a file with @dominikl 's local build from this PR. I have the same problem as @dominikl with the merge-ci artifact.

lgtm and the test is green

@jburel
Copy link
Member Author

jburel commented Dec 18, 2023

Maybe a problem with merge-ci. Maybe some PR that should not be included are included. We have seen that previously

@jburel jburel merged commit 4e8d075 into ome:master Dec 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants