Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build jinja2 #88

Closed
wants to merge 2 commits into from
Closed

Conversation

pwalczysko
Copy link
Member

I have declared

declaring jinja2 as a dependency of omero-mapr

as per #85 (comment).

@will-moore : Is there any reason why you went for the (imho much more complex) options in #87 ?

@pwalczysko
Copy link
Member Author

pwalczysko commented Oct 28, 2024

@will-moore @jburel : Maybe there was some larger plan about why not to go the declare jinja2 as dep way. But here now the tests are passing -> possibly there could be some value in simply going with the option as declared here ?

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwalczysko That's great - thanks. I started trying to fix this one way and ended up taking a more complex route, but this way is nice.

@pwalczysko
Copy link
Member Author

@jburel Do you want to merge please ? I think this would unblock @will-moore with minimal effort expended

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-plugins-push#227. See the console output for more details.
Possible conflicts:

--conflicts

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-plugins-push#228. See the console output for more details.
Possible conflicts:

--conflicts

@will-moore
Copy link
Member

Hmmm - just looking at this again because of the conflicts. I don't think I really looked at this closely before as I realise now this is updating the installation dependencies so that anyone installing mapr will also install jinja2. This is not ideal as the app has no requirement for jinja2 - it's only needed for testing because the testing setup imports omero.util which imports jinja. And it only imports omero.util to perform populate metadata, since omero.util did that before we had the omero-metadata plugin.

@@ -1,2 +1,3 @@
requests
omero-web[redis]>=5.14.0
jinja2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a dependency not required by the app

@jburel jburel closed this Oct 29, 2024
@pwalczysko pwalczysko deleted the test-from-master branch October 29, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants