-
Notifications
You must be signed in to change notification settings - Fork 102
Use \d #6423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Use \d #6423
Conversation
Interesting. What changed to make this start failing, @jburel ? |
This is due to the fact that we are running with 3.12 |
Gotcha. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This matches the language changes announced in https://docs.python.org/dev/whatsnew/3.12.html#other-language-changes
I would suggest we follow the official recommendation and use raw strings for regular expressions
@@ -70,7 +70,8 @@ def snapshot_logic(omero_version): | |||
|
|||
See gh-67 for the discussion. | |||
""" | |||
m = re.match(( | |||
re.compile() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be reverted?
Upgrading the GitHub action to run on Ubuntu 24.04 with Python 3.12 to synchronize the documentation from various repositories has led to some failures
See https://github.com/ome/omero-documentation/actions/runs/13825561909
This is the first part of the puzzle.
Changes are required in other repositories e.g. omeroweb-install and ansible