Skip to content

Add test for getObjects('MapAnnotation')#6435

Merged
dominikl merged 2 commits intoome:developfrom
will-moore:getObjectsMapAnnotation_test
Jul 25, 2025
Merged

Add test for getObjects('MapAnnotation')#6435
dominikl merged 2 commits intoome:developfrom
will-moore:getObjectsMapAnnotation_test

Conversation

@will-moore
Copy link
Member

@will-moore will-moore commented Jul 15, 2025

What this PR does

Adds test for fix at ome/omero-py#464

Also, I noticed that the checks like assert m.OMERO_TYPE == mapAnn.OMERO_TYPE only test that the wrapper is the correct type, NOT that the underlying omero.model object is correct (which is what's fixed in the PR above). So I added this check for the other types above.

Testing this PR

  1. Should be tested by integration tests - best to also try exclude the PR above to check that test fails

cc @dominikl

@will-moore
Copy link
Member Author

docker build failed with...

#37 1.634 retrieve:
#37 1.634 :: Apache Ivy 2.4.0 - 20141213170938 :: http://ant.apache.org/ivy/ ::
#37 1.639 :: loading settings :: file = /src/etc/ivysettings.xml
#37 1.799 WARNING: An illegal reflective access operation has occurred
#37 1.799 WARNING: Illegal reflective access by org.apache.ivy.util.url.IvyAuthenticator (file:/src/lib/repository/ivy-2.4.0.jar) to field java.net.Authenticator.theAuthenticator
#37 1.799 WARNING: Please consider reporting this to the maintainers of org.apache.ivy.util.url.IvyAuthenticator
#37 1.799 WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
#37 1.799 WARNING: All illegal access operations will be denied in a future release
#37 422.6 :: problems summary ::
#37 422.6 :::: WARNINGS
#37 422.6 		[FAILED     ] cisd#jhdf5;19.04.1!jhdf5.jar: Downloaded file size doesn't match expected Content Length for https://artifacts.openmicroscopy.org/artifactory/maven/cisd/jhdf5/19.04.1/jhdf5-19.04.1.jar. Please retry. (337356ms)
#37 422.6 		[FAILED     ] cisd#jhdf5;19.04.1!jhdf5.jar: Downloaded file size doesn't match expected Content Length for https://artifacts.openmicroscopy.org/artifactory/maven/cisd/jhdf5/19.04.1/jhdf5-19.04.1.jar. Please retry. (337356ms)
#37 422.6 	==== ome-artifactory: tried
#37 422.6 	  https://artifacts.openmicroscopy.org/artifactory/maven/cisd/jhdf5/19.04.1/jhdf5-19.04.1.jar
#37 422.6 		::::::::::::::::::::::::::::::::::::::::::::::
#37 422.6 		::              FAILED DOWNLOADS            ::
#37 422.6 		:: ^ see resolution messages for details  ^ ::
#37 422.6 		::::::::::::::::::::::::::::::::::::::::::::::
#37 422.6 		:: cisd#jhdf5;19.04.1!jhdf5.jar
#37 422.6 		::::::::::::::::::::::::::::::::::::::::::::::
#37 422.6 
#37 422.6 
#37 422.6 :: USE VERBOSE OR DEBUG MESSAGE LEVEL FOR MORE DETAILS
#37 422.6 
#37 422.6 BUILD FAILED
#37 422.6 /src/build.xml:102: The following error occurred while executing this line:
#37 422.6 /src/components/antlib/resources/global.xml:316: The following error occurred while executing this line:
#37 422.6 /src/components/antlib/resources/lifecycle.xml:67: impossible to resolve dependencies:
#37 422.6 	resolve failed - see output for details
#37 422.6 
#37 422.6 Total time: 7 minutes 2 seconds
#37 ERROR: process "/bin/sh -c ./build.py" did not complete successfully: exit code: 1

Any ideas @jburel?

@will-moore will-moore force-pushed the getObjectsMapAnnotation_test branch from 32b9233 to 5d57bab Compare July 22, 2025 10:40
@will-moore
Copy link
Member Author

Since this test doesn't seem to be fixed by ome/omero-py#464 (see test links there), I've used the query from that PR directly in the test to check if that query works... cc @dominikl

@dominikl dominikl merged commit f506a55 into ome:develop Jul 25, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in OMERO.server 5.6.17 Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants