Add test for getObjects('MapAnnotation')#6435
Merged
dominikl merged 2 commits intoome:developfrom Jul 25, 2025
Merged
Conversation
37f518c to
63eeb74
Compare
Member
Author
|
docker build failed with... Any ideas @jburel? |
32b9233 to
5d57bab
Compare
Member
Author
|
Since this test doesn't seem to be fixed by ome/omero-py#464 (see test links there), I've used the query from that PR directly in the test to check if that query works... cc @dominikl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds test for fix at ome/omero-py#464
Also, I noticed that the checks like
assert m.OMERO_TYPE == mapAnn.OMERO_TYPEonly test that the wrapper is the correct type, NOT that the underlyingomero.modelobject is correct (which is what's fixed in the PR above). So I added this check for the other types above.Testing this PR
cc @dominikl