-
Couldn't load subscription status.
- Fork 118
pkg/generator: use the qualified ref filename so it can be found #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/generator: use the qualified ref filename so it can be found #375
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
===========================================
- Coverage 76.58% 45.88% -30.71%
===========================================
Files 24 56 +32
Lines 1892 5551 +3659
===========================================
+ Hits 1449 2547 +1098
- Misses 354 2763 +2409
- Partials 89 241 +152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
38c25e3 to
6a63f7b
Compare
6a63f7b to
9528ffd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
=======================================
Coverage ? 42.16%
=======================================
Files ? 61
Lines ? 6602
Branches ? 0
=======================================
Hits ? 2784
Misses ? 3546
Partials ? 272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mgabeler-lee-6rs can you please provide some examples and/or testcases here? |
|
I'll dig up something proper, but the rough issue IIRC is with |
9528ffd to
755bd50
Compare
755bd50 to
b444fbd
Compare
|
@omissis I was able to narrow down my production case that broke on this to a fairly minimal reproducer as a test case. You can cherry-pick the test over to While paths are involved, it doesn't require the |
|
I will take a look, thanks @mgabeler-lee-6rs |
b444fbd to
4351740
Compare
When generating types for a set of schemas with deeply nested refs across several subdirectories, it can fail due to not joining the parent file's base path (directory).
The properly qualified path was already computed, just need to use it!