Skip to content

Conversation

@perher
Copy link
Contributor

@perher perher commented Oct 19, 2025

First set of subschema improvements taken from #473

@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

❌ Patch coverage is 10.48951% with 512 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@4b5de3c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tests/data/core/anyOf/anyOfMultipleRequired.go 0.00% 124 Missing ⚠️
tests/data/core/allOf/allOfMultipleRequired.go 0.00% 118 Missing ⚠️
tests/data/core/anyOf/anyOfWithDirectProperties.go 0.00% 86 Missing ⚠️
tests/data/core/anyOf/anyOf.ref.go 0.00% 80 Missing ⚠️
tests/data/core/allOf/allOfWithDirectProperties.go 0.00% 76 Missing ⚠️
pkg/schemas/model.go 70.00% 10 Missing and 5 partials ⚠️
pkg/generator/schema_generator.go 70.58% 6 Missing and 4 partials ⚠️
pkg/schemas/types.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage        ?   39.59%           
=======================================
  Files           ?       66           
  Lines           ?     7147           
  Branches        ?        0           
=======================================
  Hits            ?     2830           
  Misses          ?     4039           
  Partials        ?      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perher
Copy link
Contributor Author

perher commented Oct 19, 2025

Hey @omissis I've extracted first set of changes from my mega PR #473, to make review easier.

Let me know if you want me to split this out further.

@omissis
Copy link
Owner

omissis commented Oct 19, 2025

oh, thank you! I was rebasing and fixiing conflicts in #473 and I wanted to push, but I guess this works well, too :)

@omissis omissis self-requested a review October 19, 2025 13:42
@omissis omissis added this to the v0.21.0 milestone Oct 19, 2025
@perher
Copy link
Contributor Author

perher commented Oct 19, 2025

oh, thank you! I was rebasing and fixiing conflicts in #473 and I wanted to push, but I guess this works well, too :)

Thank you for following up on this! feel free to push to either this or #473 as you wish

@omissis
Copy link
Owner

omissis commented Oct 19, 2025

yeah I think I will start with this one, thanks!

@omissis omissis merged commit 90a1a47 into omissis:main Oct 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v0.18.0 combination of anyof and required loses all information about object

2 participants