Subschema improvements (part 2) #481
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old behavior worked well when unmarshalling, but not so much when marshalling and emitting all fields even when empty
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
=======================================
Coverage ? 39.74%
=======================================
Files ? 66
Lines ? 7170
Branches ? 0
=======================================
Hits ? 2850
Misses ? 4041
Partials ? 279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@omissis second set of changes, with some potential breaking changes. Please let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second set of subschema improvements taken from #473
This contains three potentially breaking changes to existing code:
Improves the calculation of required properties for
anyOftypes, old logic would mark a property as required as long as it was required in one of the subschemas. Proposed solution changes this to mark property as required only when included in all subschemas.Adds newline after alias types, makes generated code more verbose but also more consistent with other types.
Adds state in generator to prevent duplicate processing of schemas when they are included multiple times for example both from
DoFilebut then also processed from a ref. Not sure how to unit test, but has at least no impact on existing tests.