fix: Make generateEnumType work for nillable vals #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if there is an enum type whose schema types are ["simple_type", "null"], the generator will wrap it in a struct. When it appears in a JSON body, it fails unmarshalling when only models are generated. However, when Unmarshallers are generated and there is a default value, the generated code has an error in it. This fix checks to see if the type has 2 elements and if one of them is null, it strips it out and pretends it only had one. I verified this works testing sample schemae from Github Webhook Events successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if there is an enum type whose schema types are
["simple_type", "null"], the generator will wrap it in a struct. When it appears in a JSON body, it fails unmarshalling when only models are generated. However, when Unmarshallers are generated and there is a default value, the generated code has an error in it. This fix checks to see if the type has 2 elements and if one of them is null, it strips it out and pretends it only had one.I verified this works testing sample schemae from Github Webhook Events successfully. Once I have the code checked in, I will share here for an example.