Skip to content

bugfix: remove restriction on additionalProperties types #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

bugfix: remove restriction on additionalProperties types #491

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c63a6e4
bugfix: remove restriction on additionalProperties types
codeboten Nov 12, 2025
db05a1e
fix lint
codeboten Nov 13, 2025
39d3b8c
Merge branch 'main' into codeboten/fix-490
codeboten Nov 17, 2025
de123fd
fix lint
codeboten Nov 17, 2025
aa51e06
Merge branch 'main' into codeboten/fix-490
codeboten Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions pkg/generator/schema_generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,7 @@ import (
"github.com/atombender/go-jsonschema/pkg/schemas"
)

var (
errEmptyInAnyOf = errors.New("cannot have empty anyOf array")
errTooManyTypesForAdditionalProperties = errors.New("cannot support multiple types for additional properties")
)
var errEmptyInAnyOf = errors.New("cannot have empty anyOf array")

const float64Type = "float64"

Expand Down Expand Up @@ -700,10 +697,6 @@ func (g *schemaGenerator) generateStructType(t *schemas.Type, scope nameScope) (

// Checking .Not here because `false` is unmarshalled to .Not = Type{}.
if t.AdditionalProperties != nil && t.AdditionalProperties.Not == nil {
if len(t.AdditionalProperties.Type) > 1 {
return nil, errTooManyTypesForAdditionalProperties
}

var (
defaultValue any = nil
fieldType codegen.Type = codegen.EmptyInterfaceType{}
Expand Down