Unpin OpenMM's Sphinx dep. #909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we can safely unpin OpenMM's sphinx dependency from 1.5.6. I have tested locally and it appears to work. We also need to unpin sphinx if we want to build on Python 3.7 since they are not making the old versions of sphinx on Py37. We should not need to trigger new builds for Py 27, 35, or 36 since no code changes here, just the way the docs are compiled.
|
That should be fine. The problem that required pinning Sphinx was fixed in openmm/openmm#2080. |
jchodera
added a commit
to omnia-md/conda-dev-recipes
that referenced
this pull request
Sep 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can safely unpin OpenMM's sphinx dependency from 1.5.6. I have tested locally and it appears to work.
We also need to unpin sphinx if we want to build on Python 3.7 since they are not making the old versions of sphinx on Py37.
We should not need to trigger new builds for Py 27, 35, or 36 since no code changes here, just the way the docs are compiled.
cc @peastman