+support for encoders (under additive_indices) and mute toggles for W… #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my version of Deej I wanted to use Encoders. New stuff:
Config has additive_indices array of ints now. Inputs that are present in that array become additive instead of absolute. Mostly needed for encoders so that we can jump between windows with deej.current and always add/reduce volume
Arduino can send a flag that will tell deej on PC to toggle mute on a session. Made it a toggle flag to support deej.current again
Reworked data transfer to produce uint16 with both the value ranging -1023:1023 (negatives to support additive values) and a boolean flag for mute. Still have 4 bits leftover maybe for some additional stuff.