Fix EXP Headers for ddi tables #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
requested review from
bmyates,
lisanna-dettwyler,
Jemale,
rwmcguir and
aravindksg
matcabral
reviewed
Oct 14, 2024
| zet_pfnMetricGroupCalculateMultipleMetricValuesExp_t pfnCalculateMultipleMetricValuesExp; | ||
| zet_pfnMetricGroupGetGlobalTimestampsExp_t pfnGetGlobalTimestampsExp; | ||
| zet_pfnMetricGroupGetExportDataExp_t pfnGetExportDataExp; | ||
| zet_pfnMetricGroupCalculateMetricExportDataExp_t pfnCalculateMetricExportDataExp; | ||
| zet_pfnMetricGroupCreateExp_t pfnCreateExp; |
There was a problem hiding this comment.
shouldn't this go at the end of the struct?
There was a problem hiding this comment.
that would break backwards compatibility, the version from v1.9.3 had this symbol in this place. I am simply returning it to the right place.
There was a problem hiding this comment.
based on testing with #217 this may not be necessary in this case.
bmyates
reviewed
Oct 14, 2024
| ze_pfnCommandListUpdateMutableCommandWaitEventsExp_t pfnUpdateMutableCommandWaitEventsExp; | ||
| ze_pfnCommandListImmediateAppendCommandListsExp_t pfnImmediateAppendCommandListsExp; | ||
| ze_pfnCommandListGetNextCommandIdWithKernelsExp_t pfnGetNextCommandIdWithKernelsExp; | ||
| ze_pfnCommandListUpdateMutableCommandKernelsExp_t pfnUpdateMutableCommandKernelsExp; |
There was a problem hiding this comment.
thisn is not the same ordering i get with update to spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.