Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to add missing zeKernelGetExp API and header updates #233

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix to add missing zeKernelGetExp API and header updates #233

merged 1 commit into from
Nov 14, 2024

Conversation

nrspruit
Copy link
Contributor

No description provided.

@nrspruit nrspruit marked this pull request as draft November 12, 2024 15:36
aravindksg
aravindksg reviewed Nov 13, 2024
View reviewed changes
Copy link

@aravindksg aravindksg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, so we are manually adding this API due to the spacing issue in the yml file in the spec right? but we need to fix that spacing issue for future releases of spec? and if we fix in yml file then will we have any issues with reordering ddi tables / any other compat issues that we have run into recently?

@nrspruit
Copy link
Contributor Author

changes lgtm, so we are manually adding this API due to the spacing issue in the yml file in the spec right? but we need to fix that spacing issue for future releases of spec? and if we fix in yml file then will we have any issues with reordering ddi tables / any other compat issues that we have run into recently?

This is not manually added, this is generated after the fix I have to the spec that failed to generate this code. I have this in a draft until the fix I have posted is added to the spec repo.

@nrspruit nrspruit changed the title Fix to add missing zeKernelGetExp API Fix to add missing zeKernelGetExp API and header updates Nov 13, 2024
@nrspruit nrspruit marked this pull request as ready for review November 13, 2024 22:15
@nrspruit nrspruit marked this pull request as draft November 13, 2024 22:16
@nrspruit nrspruit marked this pull request as ready for review November 13, 2024 22:23
@nrspruit nrspruit merged commit 3575f4a into oneapi-src:master Nov 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindksg aravindksg aravindksg approved these changes

@lisanna-dettwyler lisanna-dettwyler lisanna-dettwyler approved these changes

@Jemale Jemale Awaiting requested review from Jemale

@rwmcguir rwmcguir Awaiting requested review from rwmcguir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nrspruit @aravindksg @lisanna-dettwyler