Fix zer Global table init to be optional and zero init DDI tables #382
Conversation
nrspruit
force-pushed
the
fix_zer_initcheck
branch
from
8e0ee19 to
25702de
Compare
|
we may also have to uncomment the test GivenLevelZeroLoaderPresentWithLoaderInterceptEnabledAndRuntimeApiUnsupportedWhenCallingRuntimeApisAfterZeInitThenExpectErrorUnsupportedFeature and add it to CMakeList |
Great, let me do that in this review to see if there are additional issues. |
nrspruit
changed the title
nrspruit
force-pushed
the
fix_zer_initcheck
branch
3 times, most recently
from
aae21a3 to
5606512
Compare
- Fix the zer Global Init to be treated like an experimental init that cannot affect the ability to use a driver. - Zero initialize the zer DDI tables to avoid uninitialized memory reads when a driver does not implement all DDI functions. Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
fix_zer_initcheck
branch
from
5606512 to
3fd62f3
Compare
| # Add runtime_api_unsupported tests for single driver | ||
| if(init_method STREQUAL "ZeInitDrivers") | ||
| if(init_method STREQUAL "ZeInitDrivers" OR init_method STREQUAL "ZeInit") | ||
| add_runtime_api_test("runtime_api_unsupported" ${init_method} "single_driver") |
There was a problem hiding this comment.
minor:
The test name seems to have typo with runtime_api duplicated (tests_single_driver_runtime_api_runtime_api_unsupported_ZeInitDrivers)
Hence we could rename runtime_api_unsupported -> unsupported
Similarly at 623 aswell
There was a problem hiding this comment.
Other than this, looks good to me!
2 participants
cannot affect the ability to use a driver.
when a driver does not implement all DDI functions.