Set cmake options before including helpers #2338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
approved these changes
Nov 18, 2024
kbenzie
approved these changes
Nov 18, 2024
Previously we defined options after including `helpers.cmake`. However, on the first cmake invocation, this means that it doesn't have visibility of the default values. This defines the options before the import, so they are visible to `helpers.cmake`.
RossBrunton
force-pushed
the
ross/optorder
branch
from
34a7d9d
to
5f2c2c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we defined options after including
helpers.cmake. However,on the first cmake invocation, this means that it doesn't have
visibility of the default values.
This defines the options before the import, so they are visible to
helpers.cmake.