1268 - inbox UI Android native integration #2800
Open
lealobanov wants to merge 9 commits into1194-activity-uifrom
Open
1268 - inbox UI Android native integration #2800lealobanov wants to merge 9 commits into1194-activity-uifrom
lealobanov wants to merge 9 commits into1194-activity-uifrom
Conversation
- Add ADD_TOKENS to RNBridge.ScreenType and InitialRoute enums - Handle ADD_TOKENS in ReactNativeActivity getScreenName/getRouteName - Replace AddTokenActivity/AddCustomTokenActivity launch in WalletHeaderPresenter with ReactNativeActivity.launch(ADD_TOKENS) for both Flow and EVM accounts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When closeRN is called with a flowIdentifier, fetch the full TokenInfo from the API, execute cadenceEnableToken, and push the transaction to the bubble stack before closing the activity. Backward compatible — null id retains the existing finish() behavior. Closes #1275
EVM accounts should open AddCustomTokenActivity (manual ERC-20 address import), while Flow accounts use the RN Add Tokens catalog screen. The check was accidentally removed when the RN redirect was added. Closes #1275
Close the activity on the UI thread right away so the user isn't waiting on the API fetch and Cadence tx. The token lookup and tx submission continue in the background; the bubble stack shows tx progress. Closes #1275
The API response does not include a flowIdentifier field, so matching solely on it.flowIdentifier always returned null and no transaction was executed. contractId() constructs the same A.<address>.<contractName> format that RN now passes, so fall back to it when flowIdentifier is absent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Delete AddTokenActivity, NftCollectionListActivity, and all associated presenters, adapters, view models, dialogs, and layout files that were replaced by the React Native screens. Remove their AndroidManifest entries. Closes #1286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #???
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)