Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKG -- [fcl] Default to localStorage #1797

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nialexsan
Copy link
Contributor

@nialexsan nialexsan commented Oct 31, 2023

original PR:
#1782
Reverts #1796

Copy link

changeset-bot bot commented Oct 31, 2023

🦋 Changeset detected

Latest commit: ad0c3e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/fcl Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nialexsan nialexsan changed the title Revert "Revert "PKG -- [fcl] Default to localStorage"" PKG -- [fcl] Default to localStorage Oct 31, 2023
@jribbink
Copy link
Contributor

jribbink commented Nov 1, 2024

I just pushed some changes to update this with the master branch, etc. It works now, but there's one unfortunate bug.

Flow Wallet (or any extension wallets) will overwrite the default configuration of FCL (fcl.storage.default), meaning that these changes will appear not to do anything (FW overwrites with sessionStorage). It's related to some of the long-standing global state issues in FCL. I need to look into what the best solution is here.

Maybe it's just a good time to just move away from the fcl.storage.default key in favour of more explicit dependency injection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants