Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues where time-to-seal was NaN #6624

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AndriiDiachuk
Copy link
Contributor

The new time_to_seal metric was reporting NaN for values. Fixed this issue.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.83%. Comparing base (a80d4c5) to head (40d5c3e).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
module/metrics/transaction.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6624      +/-   ##
==========================================
+ Coverage   41.21%   42.83%   +1.62%     
==========================================
  Files        2054     1621     -433     
  Lines      182340   148295   -34045     
==========================================
- Hits        75154    63526   -11628     
+ Misses     100886    79307   -21579     
+ Partials     6300     5462     -838     
Flag Coverage Δ
unittests 42.83% <0.00%> (+1.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants