-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] check for correct err in ReadJSON method #7065
base: master
Are you sure you want to change the base?
[Access] check for correct err in ReadJSON method #7065
Conversation
Co-authored-by: Peter Argue <[email protected]>
…The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…:The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…' of github.com:The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…ot-indexed' of github.com:onflow/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…github.com:onflow/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…' of github.com:The-K-R-O-K/flow-go into AndriiSlisarchuk/6573-pending-should-return-immediately
…' into UlianaAndrukhiv/6641-websockets-integration-tests
Chose better name for tests that had TODOs left.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7065 +/- ##
=========================================
Coverage 41.15% 41.15%
=========================================
Files 2132 2139 +7
Lines 187058 188557 +1499
=========================================
+ Hits 76975 77595 +620
- Misses 103635 104464 +829
- Partials 6448 6498 +50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Closes #7045
Branched off #6641
Removed
websocket.ErrCloseSent
in favor ofwebsocket.CloseError