Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] check for correct err in ReadJSON method #7065

Open
wants to merge 155 commits into
base: master
Choose a base branch
from

Conversation

illia-malachyn
Copy link
Contributor

@illia-malachyn illia-malachyn commented Feb 19, 2025

Closes #7045
Branched off #6641

Removed websocket.ErrCloseSent in favor of websocket.CloseError

Guitarheroua and others added 30 commits November 15, 2024 15:18
…The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…:The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
Guitarheroua and others added 23 commits January 31, 2025 14:44
…' of github.com:The-K-R-O-K/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…ot-indexed' of github.com:onflow/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…github.com:onflow/flow-go into UlianaAndrukhiv/6641-websockets-integration-tests
…' of github.com:The-K-R-O-K/flow-go into AndriiSlisarchuk/6573-pending-should-return-immediately
…' into UlianaAndrukhiv/6641-websockets-integration-tests
Chose better name for tests that had TODOs left.
@illia-malachyn illia-malachyn requested a review from a team as a code owner February 19, 2025 15:02
@illia-malachyn illia-malachyn changed the title Illia malachyn/7045 check for correct err in read method [Access] check for correct err in read method Feb 19, 2025
@illia-malachyn illia-malachyn changed the title [Access] check for correct err in read method [Access] check for correct err in ReadJSON method Feb 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 57.97468% with 166 lines in your changes missing coverage. Please review.

Project coverage is 41.15%. Comparing base (8665c07) to head (d4d0bda).
Report is 593 commits behind head on master.

Files with missing lines Patch % Lines
...s/rpc/backend/transaction_subscription_metadata.go 64.03% 31 Missing and 10 partials ⚠️
engine/access/rest/common/utils.go 47.91% 24 Missing and 1 partial ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 17 Missing ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 17 Missing ⚠️
.../access/rpc/backend/backend_stream_transactions.go 72.13% 12 Missing and 5 partials ⚠️
engine/access/rest/websockets/controller.go 62.79% 15 Missing and 1 partial ⚠️
engine/access/rest/util/converter.go 0.00% 8 Missing ⚠️
.../rest/websockets/data_providers/events_provider.go 28.57% 4 Missing and 1 partial ⚠️
access/api.go 0.00% 4 Missing ⚠️
...ockets/data_providers/account_statuses_provider.go 40.00% 2 Missing and 1 partial ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7065     +/-   ##
=========================================
  Coverage   41.15%   41.15%             
=========================================
  Files        2132     2139      +7     
  Lines      187058   188557   +1499     
=========================================
+ Hits        76975    77595    +620     
- Misses     103635   104464    +829     
- Partials     6448     6498     +50     
Flag Coverage Δ
unittests 41.15% <57.97%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Investigate gorrilla ReadJSON return error on Close
5 participants