Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.39] Remove DKG submission backward-compat logic #7097

Draft
wants to merge 1 commit into
base: v0.39
Choose a base branch
from

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Feb 26, 2025

Backport of #7096

v0.39.0 includes several backward-compatibility measures to allow one software version to operate both before and after the protocol state upgrade. This PR removes the backward-compatibility logic for DKG result submission (only submit using v2 transaction format).

⚠️ For live networks, this change must be deployed strictly after the Protocol State Upgrade Process. Specifically after both the protocol state upgrade and after the smart contract upgrade.

Deployment to Testnet/Mainnet

We are performing a staged upgrade process to Protocol State v2, with Testnet first and Mainnet next. We will test this change on Testnet following its upgrade, but would like to make it difficult for Mainnet operators to accidentally upgrade prematurely to this version before the Mainnet upgrade is complete.

  • Tag an alpha version off this branch, like v0.39.1-unsafe-compat-disabled and build images
  • Following Testnet upgrade, deploy v0.39.1-unsafe-compat-disabled to Testnet
  • Following Mainnet upgrade, merge and tag a regular release v0.39.1 and build images
  • Deploy v0.39.1 to Mainnet

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.26%. Comparing base (ad1076f) to head (f4129c1).

Additional details and impacted files
@@            Coverage Diff             @@
##            v0.39    #7097      +/-   ##
==========================================
+ Coverage   41.24%   41.26%   +0.01%     
==========================================
  Files        2138     2138              
  Lines      188585   188495      -90     
==========================================
- Hits        77782    77776       -6     
+ Misses     104307   104226      -81     
+ Partials     6496     6493       -3     
Flag Coverage Δ
unittests 41.26% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlexHentschel AlexHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 ✨

Copy link
Member

@durkmurder durkmurder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants