-
Notifications
You must be signed in to change notification settings - Fork 203
[Cadence VM] Improve compiler/VM / interpreter comparison tool #8221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/cadence-vm
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
|
||
| g.Go(func() error { | ||
|
|
||
| time.Sleep(flagSubscriptionDelay) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this delay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the when the subscription notifies about a new sealed block, the registers for it are not immediately available, and execution will fail. Once I waited for a few seconds, the registers became available, so I added a conservative default of about half a minute
Uh oh!
There was an error while loading. Please reload this page.