Skip to content

Conversation

@turbolent
Copy link
Member

@turbolent turbolent commented Dec 3, 2025

  • Add progress logging
  • Add support for subscribing to new blocks and comparing them as they are produced

@turbolent turbolent requested review from a team December 3, 2025 20:43
@turbolent turbolent requested a review from a team as a code owner December 3, 2025 20:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 0% with 145 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/util/cmd/compare-cadence-vm/cmd.go 0.00% 88 Missing ⚠️
utils/debug/api.go 0.00% 32 Missing ⚠️
cmd/util/cmd/debug-tx/cmd.go 0.00% 25 Missing ⚠️

📢 Thoughts on this report? Let us know!

@turbolent turbolent requested a review from SupunS December 4, 2025 00:02
@turbolent turbolent changed the title [Cadence VM] Add progress logging to comparison tool [Cadence VM] Improve compiler/VM / interpreter comparison tool Dec 4, 2025
@turbolent turbolent requested a review from a team December 10, 2025 19:51

g.Go(func() error {

time.Sleep(flagSubscriptionDelay)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this delay?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the when the subscription notifies about a new sealed block, the registers for it are not immediately available, and execution will fail. Once I waited for a few seconds, the registers became available, so I added a conservative default of about half a minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants