[Storehouse] Storehouse checkpoint validator #8257
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
zhangchiqing
force-pushed
the
leo/storehouse-checkpoint-validator
branch
from
fdab802 to
8212b18
Compare
zhangchiqing
requested review from
fxamacker,
janezpodhostnik and
peterargue
fxamacker
reviewed
Dec 16, 2025
Member
fxamacker
left a comment
fxamacker
left a comment
There was a problem hiding this comment.
I left some comments about a possible deadlock and also about removing some limitations from the current approach.
fxamacker
approved these changes
Dec 17, 2025
| } | ||
|
|
||
| // IsErrMismatch returns true if the given error is an ErrMismatch or wraps an ErrMismatch. | ||
| func IsErrMismatch(err error) bool { |
Member
There was a problem hiding this comment.
IsErrMismatch doesn't appear to be used.
Comment on lines
23
to
29
| type ErrMismatch struct { | ||
| RegisterID flow.RegisterID | ||
| Height uint64 | ||
| StoredLength int | ||
| ExpectedLength int | ||
| Message string | ||
| } |
Member
There was a problem hiding this comment.
Maybe also include StoredData and ExpectedData in the ErrMismatch struct.
Comment on lines
136
to
142
| log.Error(). | ||
| Str("owner", mismatchErr.RegisterID.Owner). | ||
| Str("key", mismatchErr.RegisterID.Key). | ||
| Uint64("height", mismatchErr.Height). | ||
| Int("stored_length", mismatchErr.StoredLength). | ||
| Int("expected_length", mismatchErr.ExpectedLength). | ||
| Msg("register value mismatch") |
Member
There was a problem hiding this comment.
Maybe we can simplify this when ErrMismatch.Error() returns a complete message with owner, key, height, and other information.
Suggested change
| log.Error(). | |
| Str("owner", mismatchErr.RegisterID.Owner). | |
| Str("key", mismatchErr.RegisterID.Key). | |
| Uint64("height", mismatchErr.Height). | |
| Int("stored_length", mismatchErr.StoredLength). | |
| Int("expected_length", mismatchErr.ExpectedLength). | |
| Msg("register value mismatch") | |
| log.Error().Err(err).Msg("register value mismatch") |
Comment on lines
31
to
37
| func (e *ErrMismatch) Error() string { | ||
| if e.Message != "" { | ||
| return e.Message | ||
| } | ||
| return fmt.Sprintf("register value mismatch: owner=%s, key=%s, height=%d, stored_length=%d, expected_length=%d", | ||
| e.RegisterID.Owner, e.RegisterID.Key, e.Height, e.StoredLength, e.ExpectedLength) | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
173
to
179
| return &ErrMismatch{ | ||
| RegisterID: registerID, | ||
| Height: height, | ||
| StoredLength: 0, | ||
| ExpectedLength: len(payload.Value()), | ||
| Message: fmt.Sprintf("register not found in store: owner=%s, key=%s, height=%d", registerID.Owner, registerID.Key, height), | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #8244
This PR implemented a basic validator to check the consistency between payloads stored in checkpoint file and in storehouse.
Tested the validation with Testnet EN3, it took 42 mins to complete the validation, and no mismatch was found 🎉