Update mainnet27 historic Access node to return errors for blocks after hardfork #8267

peterargue · 2025-12-27T22:07:41Z

Updates for the mainnet27 historic Access node to return errors for data related to blocks after the hardfork. This also disables ingestion of p2p messages from the network to avoid the node inadvertently consuming any new data.

[v0.43] Update to Cadence v1.7.2

…ompiler complications)

coderabbitai · 2025-12-27T22:07:46Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch peter/mainnet27-historic-an

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov-commenter · 2025-12-27T22:10:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

engine/access/rpc/backend/transactions/transactions.go

state/protocol/badger/state.go

Co-authored-by: Jordan Schalm <[email protected]>

jordanschalm

Do we need a similar check for the GetBlock endpoint?

peterargue · 2025-12-27T22:54:44Z

Do we need a similar check for the GetBlock endpoint?

the other endpoints use storage blocks/headers objects to get the block, which will return an error

engine/access/rpc/backend/transactions/transactions.go

state/protocol/badger/state.go

…est-protocol-state # Conflicts: # fvm/meter/memory_meter.go # fvm/meter/meter_test.go # go.mod # go.sum # insecure/go.mod # insecure/go.sum # integration/go.mod # integration/go.sum

Co-authored-by: Alexander Hentschel <[email protected]>

…l-state [Update mainnet27 historic AN] Archive Thresholds enforced inside Storage Operations

• fixed iteration over children: now filtering out children / descendant that are beyond the archive boundaries

…ren index

[Update mainnet27 historic AN] Archive Thresholds enforced by descendants search

… children`

…rtificate for view comparison

[Update mainnet27 historic AN] retrieving QC

turbolent and others added 15 commits October 22, 2025 11:52

update to Cadence v1.7.2

a4d9c1e

adjust code to API changes

8595394

add weights for new memory kinds

321ba54

adjust tests to new computation and memory metering

a7bd990

adjust code to API changes

ceb0dfa

match behaviour of internal build

76b50fb

only check for weight existence, allow explicit zero weights

f92193e

Merge pull request #8068 from onflow/bastian/v0.43-update-cadence-v1.7.2

fabd124

[v0.43] Update to Cadence v1.7.2

basic sketch of fix (including AI contributions for comments fixing c…

d5832e3

…ompiler complications)

sanity check

ec83114

consolidation

5983ae1

more consolidation

aeac26e

reduced change surface

3608276

Update mainnet27 Access API to return errors for blocks after hardfork

c398846

including sentinel

5596513

peterargue requested a review from a team as a code owner December 27, 2025 22:07

jordanschalm reviewed Dec 27, 2025

View reviewed changes

engine/access/rpc/backend/transactions/transactions.go Outdated Show resolved Hide resolved

state/protocol/badger/state.go Outdated Show resolved Hide resolved

AlexHentschel and others added 5 commits December 27, 2025 14:16

consolidation

369b3f4

updating payload with checks agains archive thresholds

f892dcb

fix lint

9882600

Update engine/access/rpc/backend/transactions/transactions.go

8c9e16c

Co-authored-by: Jordan Schalm <[email protected]>

removing unused constants

45178a7

jordanschalm reviewed Dec 27, 2025

View reviewed changes

fix lint

838caf8

jordanschalm approved these changes Dec 27, 2025

View reviewed changes

AlexHentschel added 2 commits December 27, 2025 14:59

documentation

ad517f6

comment

5c7ca30

disabled history cutoff by setting constants to max values,

f7df3d4

AlexHentschel approved these changes Dec 27, 2025

View reviewed changes

AlexHentschel and others added 12 commits December 27, 2025 15:42

Merge branch 'peter/mainnet27-historic-an' into alex/v0.43_hotfix_lat…

997b4f8

…est-protocol-state # Conflicts: # fvm/meter/memory_meter.go # fvm/meter/meter_test.go # go.mod # go.sum # insecure/go.mod # insecure/go.sum # integration/go.mod # integration/go.sum

Update engine/access/rpc/backend/transactions/transactions.go

a2b269d

Co-authored-by: Alexander Hentschel <[email protected]>

final values for Archive history cutoff

4a2a7f1

switch to new consts

e41b4fc

Apply suggestions from code review

59646fc

Co-authored-by: Alexander Hentschel <[email protected]>

Merge pull request #8265 from onflow/alex/v0.43_hotfix_latest-protoco…

524e564

…l-state [Update mainnet27 historic AN] Archive Thresholds enforced inside Storage Operations

linted code

ced760a

• renamed the BeyondArchiveThreshold by appending "Error"

6782b6c

• fixed iteration over children: now filtering out children / descendant that are beyond the archive boundaries

extended documentation of storage withholding algorithm for the child…

5dcbb71

…ren index

documentation regarding archive thresholds for Snapshot.Descendants()

a27a792

clarified, improved documentation

e708eed

polish

22e2355

AlexHentschel mentioned this pull request Dec 28, 2025

[Update mainnet27 historic AN] Archive Thresholds enforced by descendants search #8268

Merged

AlexHentschel added 8 commits December 27, 2025 20:34

linted code

96dc4e6

updated thresholds

c444b4b

added cautionary statement and brief context on safety

f23318f

Merge pull request #8268 from onflow/alex/v0.43_hotfix_descendants

6c6ae0a

[Update mainnet27 historic AN] Archive Thresholds enforced by descendants search

fixing component follower core initialization `finalized block has no…

e968e2d

… children`

fix RetrieveQuorumCertificate to correctly use the retrieved QuorumCe…

8fe822a

…rtificate for view comparison

fixed mocks and other header implementations

8ecb08b

Merge pull request #8269 from onflow/alex/v0.43_hotfix_descendants

ce4a79c

[Update mainnet27 historic AN] retrieving QC

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update mainnet27 historic Access node to return errors for blocks after hardfork #8267

Update mainnet27 historic Access node to return errors for blocks after hardfork #8267

Uh oh!

peterargue commented Dec 27, 2025

Uh oh!

coderabbitai bot commented Dec 27, 2025

Review skipped

Uh oh!

codecov-commenter commented Dec 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

jordanschalm left a comment

Uh oh!

peterargue commented Dec 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Update mainnet27 historic Access node to return errors for blocks after hardfork #8267

Are you sure you want to change the base?

Update mainnet27 historic Access node to return errors for blocks after hardfork #8267

Uh oh!

Conversation

peterargue commented Dec 27, 2025

Uh oh!

coderabbitai bot commented Dec 27, 2025

Review skipped

Uh oh!

codecov-commenter commented Dec 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

jordanschalm left a comment

Choose a reason for hiding this comment

Uh oh!

peterargue commented Dec 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-commenter commented Dec 27, 2025 •

edited

Loading