Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: Crypto, KeyPair, PrivateKey, PublicKey #6

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

lealobanov
Copy link
Collaborator

@lealobanov lealobanov commented Jan 25, 2024

Description

Adds unit tests for:
com.nftco.flow.sdk.crypto.Crypto;
com.nftco.flow.sdk.crypto.KeyPair;
com.nftco.flow.sdk.crypto.PrivateKey;
com.nftco.flow.sdk.crypto.PublicKey;


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@lealobanov lealobanov changed the title Unit tests: Crypto, KeyPair, PrivateKey, PublicKey (WIP) Unit tests: Crypto, KeyPair, PrivateKey, PublicKey Jan 25, 2024
}

@Test
fun `Normalize signature`() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently failing - need to investigate

}

@Test
fun `Extract RS from valid signature`() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently failing - need to investigate

Copy link

github-actions bot commented Jan 25, 2024

Unit Test Results

  53 files  ±0    53 suites  ±0   29s ⏱️ ±0s
259 tests ±0  259 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 30d0ab7. ± Comparison against base commit 30d0ab7.

♻️ This comment has been updated with latest results.

@lealobanov lealobanov changed the title (WIP) Unit tests: Crypto, KeyPair, PrivateKey, PublicKey Unit tests: Crypto, KeyPair, PrivateKey, PublicKey Feb 14, 2024
@lealobanov lealobanov marked this pull request as ready for review February 14, 2024 09:27
@franklywatson franklywatson merged commit 30d0ab7 into main Feb 14, 2024
2 checks passed
@franklywatson franklywatson deleted the crypto-test branch February 14, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants