Use units based on powers of 2 #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects how they are interpreted in the code.
|
Thanks, this is a cool kind of cleanup. Thanks a lot for adding an entry to the release docs! |
|
Oh, I didn't see this PR. I was working in parallel on another PR that actually used MB, GB, and so on. For completeness, as we opted for the binary units, the guideline on Hoeffding trees should also be updated! Thanks for the PR @e10e3! |
|
I will take care of the tree guidelines! Edit: done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where unit multiples of the byte are used, this PR uses the unambiguous name of the unit.
Binary units have a different symbol (KiB, MiB) to distinguish them from the general-use decimal units (kB, MB). River only uses the binary units.
The only functional change is in
tree.utils.calculate_object_size, where the recognised valued for the second (optional) argument were changed. This optional argument was not used in River.Closes #1582