New MyPy configuration for per-module type completeness #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an override for all modules while they are not annotated.
The registry variable of Gymnasium environments is located in the 'registration' module. This variables is also imported by the 'envs' module, but not explictely re-exported. This means the previous code was correct at runtime, but MyPy raised easily-corrected warnings.
These rules do not cause errors in the current code, meaning they can be enabled without harm.
MaxHalford
approved these changes
Aug 25, 2024
smastelini
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1592, this PR enables MyPy's strict mode by default for the repository.
Since none of the modules are fully annotated yet, they have an override to disable the extra rules.
Because MyPy has a configuration bug, the settings enabled by the strict mode need to be disabled individually.
Only the options that raised new errors are disabled in the override : this means that MyPy will now perform more checks over the code.