Make mini-batch TF-IDF raise an exception #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently no mini-batch implementation of TF-IDF. To prevent Python from using the methods from the parent class BagOfWords (which would give incorrect results), we add the methods to TF-IDF and raise an error.
The paramters were documented in the docstring but were not in the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature _extraction.TFIDFhas no explicit implementation of the mini-batch methodslearn_manyandtransform_many, meaning that Python will fall back on the ones provided by its parentfeature _extraction.BagOfWords. This causes TF-IDF to have a different behaviour in single-instance and in mini-batch mode.This PR is a band-aid that adds the methods for TF-IDF to make it explicit they are not supported. Both will raise an exception when called.
A true mini-batch version could be added at a later point.
Fixes #1629