Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature omniring #100

Open
wants to merge 30 commits into
base: omniring-support
Choose a base branch
from

Conversation

reyvababtista
Copy link
Collaborator

This PR adds OmniRing wearable connectivity and listener into Beiwe. More information about OmniRing can be found here: https://www.cse.psu.edu/~mkg31/projects/omniring/

Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit e663fff2ffbb5a7895db6aff1e64d287902bfe05)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit 1c77565998c66f8e930ae2e075a78c0ff47b36a0)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit d15aaedc93ad5ef54f37e42b3f162295665df19c)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit e7d03f92584829c59201be56ab8d727f7eb75e5a)
Signed-off-by: Reyva Babtista <[email protected]>

(cherry picked from commit e008e433e7c6ee7f8f4361abf05432de813571d2)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit c1311ab44f209e50ad4baadaabb8fc931bccc5a5)
Signed-off-by: Reyva Babtista <[email protected]>

(cherry picked from commit 2c4d0693743e64f41d85be3ac8347146e1d02b3f)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit e59bd2a3b91fa312c05a7c288623f7e782d56d9e)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit 86f8b2ce11df215da29b54d7b19680b2f6fb66a5)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit 1ee3a59c7a151bfbea05a1fb4aa6c007ed537eb7)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit a4f404df0044977aa0d872a9ffd4e44d16112ce3)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit c20bf4d5981db06ced639dd4a83a3dd9ec47231f)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit 450da3db1c10740ce99c3ffa47e51085bbb54c98)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit 16354187ddb735c818db8c2392cfd72394985a45)
Signed-off-by: Reyva Babtista <[email protected]>

(cherry picked from commit 8832680c02dff6110771b8b94d740004c35875c4)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit 521451f185cb16356ca92ad959d2d2362efd7836)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit 57412ae14e602d409ccfd231dccb82e3d3dd3b7c)
Signed-off-by: Reyva Babtista <[email protected]>

(cherry picked from commit fbf3389eb77ad32783c99575c8c557a596907dd5)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit 2f20432ad081a00b10b61c534e791430d85802e5)
Signed-off-by: Reyva Babtista <[email protected]>
(cherry picked from commit 4bf42de7f9b6ab40324582842978c23454d6d38d)
@biblicabeebli biblicabeebli self-requested a review January 15, 2025 11:00
@biblicabeebli biblicabeebli self-assigned this Jan 15, 2025
@biblicabeebli
Copy link
Member

biblicabeebli commented Jan 15, 2025

Actions I've taken:

  • Updated staged-updates branch to be same as main, it was out-of-date. Just remove 20 older commits I made from the pull request.
  • made omniring-support branch

Questions:

  • I would like to know the Android devices you tested on. (our coverage here is limited, my test device is a Pixel... 6?)
  • [from manifest] we do need to take a look at whether bluetooth permissions changed in the past couple versions - I doubt they have.
  • two discussion items on whether there is extra metadata to log from the omniring datastream
  • make a new feature branch target to merge this into.
  • Need to think about whether we want this feature merged into the main app - other than the versioning complexity I don't have an issue.
  • Version number and changelog update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manifest looks fine, we do need to take a look at whether bluetooth permissions changed in the past couple versions.

@biblicabeebli biblicabeebli changed the base branch from staged-updates to omniring-support January 15, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants