-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable NNPA saturation by default and change the option to --nnpa-disable-saturation #3101
Conversation
…able-saturation Signed-off-by: Tung D. Le <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we change the attribute from "saturation" to "nonsaturation"? Will that save some modifications in the test case and code gen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks a good idea. Let me give it a try. Thanks! |
Signed-off-by: Tung D. Le <[email protected]>
… into nnpa-disable-saturation
Signed-off-by: Tung D. Le <[email protected]>
@jenkins-droid test this please |
@jenkins-droid test this please |
@jenkins-droid test this please |
@chentong319 I changed "saturation" to nosaturation". Thanks! |
Jenkins Linux ppc64le Build #15390 [push] Enable NNPA saturation b... started at 00:22 |
Jenkins Linux s390x Build #16409 [push] Enable NNPA saturation b... started at 00:09 |
Jenkins Linux amd64 Build #16407 [push] Enable NNPA saturation b... started at 23:09 |
Jenkins Linux amd64 Build #16407 [push] Enable NNPA saturation b... passed after 1 hr 38 min |
Jenkins Linux s390x Build #16409 [push] Enable NNPA saturation b... passed after 2 hr 2 min |
Jenkins Linux ppc64le Build #15390 [push] Enable NNPA saturation b... aborted after 2 hr 27 min |
This patch enables NNPA saturation by default to avoid
out of range
errors in running some models.The performance penalty is quite small, for example, for roberta base:
Without saturation:
With saturation: