[zdnnx] Use OMP_NUM_THREADS to control the number of threads for NNPA #3227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tung D. Le <[email protected]>
| } | ||
| // If OMP_NUM_THREADS is not set, it is the sequential mode. | ||
| const char *env = getenv("OMP_NUM_THREADS"); | ||
| zdnnx_num_procs = (env != NULL) ? atoi(env) : 1; |
There was a problem hiding this comment.
What is the difference between zdnnx_num_procs and zdnnx_num_zaius. The names feel confusing and if they are two different entities, their name should be clearer.
There was a problem hiding this comment.
Good catch! zdnnx_num_procs is not necessary any more. I just removed it and revised some variable names. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since NNPA in z17 can be remotely accessed, the use of OMP_PLACES to manually assign CPU to threads is not necessary. This patch simplifies that by using OMP_NUM_THREADS which works with both compiler-generated OMP and zdnnx's OMP.
Additionally, an environment variable
OM_NUM_ZAIU_THREADSis introduced if users want to use a different number of threads for NNPA. Otherwise, the number of threads for NNPA is the same as OMP_NUM_THREADS.