reuse sess in backend #273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinhuang007
reviewed
Oct 4, 2018
Contributor
chinhuang007
left a comment
chinhuang007
left a comment
There was a problem hiding this comment.
Can we simply use self._sess, rather than additional sess?
Collaborator
Author
|
@chinhuang007 We want tf_rep.run be stateless. |
chinhuang007
reviewed
Oct 5, 2018
onnx_tf/backend_rep.py
Outdated
| :returns: A Session object. | ||
| """ | ||
| return tf.Session(self.graph) |
Contributor
There was a problem hiding this comment.
Shouldn't this be tf.Session(graph=self.graph)?
|
Is there any chance this PR gets accepted? I was actually facing the exact problem this PR is trying to fix. |
# Conflicts: # onnx_tf/backend_rep.py
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#271