Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPG key error #59

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Fix GPG key error #59

merged 1 commit into from
Nov 13, 2019

Conversation

xhdix
Copy link
Contributor

@xhdix xhdix commented Aug 5, 2019

Close #58

@anadahz
Copy link
Contributor

anadahz commented Aug 5, 2019

The Travis build errors due to GPG key issue, see pull request: #57

@xhdix xhdix force-pushed the patch-1 branch 2 times, most recently from a578b5b to 5bef0a8 Compare August 5, 2019 18:53
@xhdix
Copy link
Contributor Author

xhdix commented Aug 5, 2019

@anadahz Can you verify the changes?

@anadahz
Copy link
Contributor

anadahz commented Aug 5, 2019

@xhdix I guess it's better to revert your changes.
Pull request (#57) is approved and should be merged soon.

@xhdix
Copy link
Contributor Author

xhdix commented Aug 6, 2019

@anadahz OK, I have reverted the changes to the .travis.yml file.
Three other files still need to be modified. I'm not sure about the changes to the file scripts/setup-dependencies.sh.

@anadahz
Copy link
Contributor

anadahz commented Aug 8, 2019

@xhdix #57 is merged. You can rebase your branch to the current master to resolve Travis errors.

@xhdix
Copy link
Contributor Author

xhdix commented Aug 11, 2019

I think everything is right now.
@hellais @bassosimone please review.

(I made the changes with the Atom editor so the extra spaces are automatically deleted)

@hellais
Copy link
Member

hellais commented Nov 13, 2019

LGTM

@hellais hellais merged commit 99cd286 into ooni:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpg: keyserver receive failed: No data
3 participants