Skip to content

f Update configs.json #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

f Update configs.json #1426

wants to merge 1 commit into from

Conversation

shystrui1199
Copy link

fix old link to a new one

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.8%. Comparing base (29fd1bd) to head (dc049c3).
Report is 23 commits behind head on main.

✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@refcell
Copy link
Collaborator

refcell commented Apr 14, 2025

These are all automatically pulled from the superchain-registry. We never manually update the configs.json file since it's generated at compile time.

I think this explorer link should be updated in the superchain-registry here first. Once that's merged into trunk, kona can update it's superchain-registry submodule to that commit to pull in those changes. With the updated superchain-registry submodule, compiling the kona-registry crate will automatically generate the configs.json file including that explorer change. Does that make sense?

Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@clabby clabby added the M-do-not-merge Meta: Do not merge label Apr 14, 2025
@shystrui1199
Copy link
Author

hello, everything ok ?

why you do not merge it ?

@refcell
Copy link
Collaborator

refcell commented Apr 17, 2025

Closing since we didn't receive any acknowledgement of my above comment. Please update this value in the superchain-registry.

@refcell refcell closed this Apr 17, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Project Tracking Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-do-not-merge Meta: Do not merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants