test(node/p2p): add extensive testing for block decoding validation #1452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theochap
force-pushed
the
theo/refactor-validity-checks
branch
from
1239834 to
d89a129
Compare
theochap
force-pushed
the
theo/add-decoding-tests
branch
from
004edf1 to
9861933
Compare
theochap
force-pushed
the
theo/refactor-validity-checks
branch
from
d89a129 to
7dcf1a9
Compare
theochap
force-pushed
the
theo/add-decoding-tests
branch
from
9861933 to
26eb292
Compare
refcell
approved these changes
Apr 17, 2025
theochap
force-pushed
the
theo/add-decoding-tests
branch
from
26eb292 to
6f3604f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR, built on top of #1451, adds a couple of unit test to ensure the block decoding operations are performed correctly and help enforce some of the validations rules from the optimism spec.
Note
Merging this PR will make progress towards #1340. It should be reviewed after #1451